-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] EuiAccordion
props table
#5974
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_5974/ |
Probably going to use the |
@thompsongl you don't need a separate prop file for class components with export const EuiAccordion = withEuiTheme<EuiAccordionProps>(EuiAccordionClass); Tested locally and both props table and playground work as expected. There's an extra |
🙇 Thanks for the assist, @constancecchen! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Preview documentation changes for this PR: https://eui.elastic.co/pr_5974/ |
Summary
Provide
EuiAccordionProps
as thewithEuiTheme
generic to allow the props table to populate correctly.export const EuiAccordion = withEuiTheme<EuiAccordionProps>(EuiAccordionClass);
Checklist